Raname WorkflowTaskTimeout to DefaultWorkflowTaskTimeout and CurrentWorkflowTaskTimeout to WorkflowTaskTimeout #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orkflowTaskTimeout to WorkflowTaskTimeout.
samarabbas
reviewed
Jul 18, 2020
| WorkflowExecutionTimeoutSeconds: executionInfo.WorkflowExecutionTimeout, | ||
| WorkflowRunTimeoutSeconds: executionInfo.WorkflowRunTimeout, | ||
| WorkflowTaskTimeoutSeconds: executionInfo.WorkflowTaskTimeout, | ||
| WorkflowTaskTimeoutSeconds: executionInfo.DefaultWorkflowTaskTimeout, |
Contributor
There was a problem hiding this comment.
Maybe we should rename the DescribeWorkflowExecutionResponse to also call it DefaultWorkflowTaskTimeoutSeconds instead of WorkflowTaskTimeoutSeconds to stay consistent.
Contributor
Author
There was a problem hiding this comment.
There are bunch of WorkflowTaskTimeoutSeconds fields in proto. Let's discuss them separately since those changes should be started from api repo anyway.
samarabbas
approved these changes
Jul 18, 2020
Contributor
samarabbas
left a comment
samarabbas
left a comment
There was a problem hiding this comment.
Looks good. One minor change and then you can land this.
alexshtin
force-pushed
the
feature/rename-current-workflow-task-timeout
branch
from
4ef9727 to
818d934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Renamed:
WorkflowTaskTimeout->DefaultWorkflowTaskTimeoutCurrentWorkflowTaskTimeout->WorkflowTaskTimeoutWhy?
For consistency.
How did you test it?
Run tests.
Potential risks
No risks.